Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-45119: [Ruby] Use #size for Arrow::Column#size backend #45133

Merged
merged 1 commit into from
Dec 31, 2024
Merged

GH-45119: [Ruby] Use #size for Arrow::Column#size backend #45133

merged 1 commit into from
Dec 31, 2024

Conversation

kou
Copy link
Member

@kou kou commented Dec 31, 2024 •
edited by github-actions bot
Loading

Rationale for this change

#n_rows is available only on Arrow::ChunkedArray. It's not available on Arrow::Array.

What changes are included in this PR?

It's available on both of Arrow::Array and Arrow::ChunkedArray.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
apacheGH-45119: [Ruby] Use #size for Arrow::Column#size backend
3f18dfb 
It's available on both of `Arrow::Array` and `Arrow::ChunkedArray`.
@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #45119 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Dec 31, 2024

+1

@kou kou merged commit 71c4b88 into apache:main Dec 31, 2024
9 checks passed
@kou kou deleted the ruby-column-size branch December 31, 2024 06:47
@kou kou removed the awaiting committer review Awaiting committer review label Dec 31, 2024
@kou kou mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kou