GH-44579: [C++] Use array type to compute min/max statistics Arrow type #45094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
kou
commented
Dec 21, 2024
| switch (array_type->id()) { | ||
| case Type::STRING: | ||
| case Type::BINARY: | ||
| case Type::FIXED_SIZE_BINARY: |
There was a problem hiding this comment.
Should we use arrow::binary() or arrow::large_binary() for Type::FIXED_SIZE_BINARY?
Approximate min/max values may not be a fixed size binary...?
github-actions
bot
added
awaiting changes
|
I'll merge this in the next week if nobody objects this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow::ArrayStatisticsuses raw C++ types such asint64_tandstd::stringfor min/max types. We need to convert raw C++ types to Arrow types when we usearrow::ArrayStatisticsfor generating statistics array. (GH-45038)We can't map
std::stringto an Arrow type. Because it may bearrow::binary(),arrow::utf8()or something.What changes are included in this PR?
Use
arrow::DataTypeinformation of associated array when we convertarrow::ArrayStatistics's min/max raw C++ types to Arrow types.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
arrow::ArrayStatistics? #44579