-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45076: [CI][Packaging][Python] Simplify dev/tasks/python-wheels/github.linux.yml #45077
Conversation
…els/github.linux.yml
@github-actions crossbow submit manylinux |
Revision: 94f0744 Submitted crossbow builds: ursacomputing/crossbow @ actions-04e938b4fa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, to be honest the only benefit to me is that if we want to migrate those jobs to standard GitHub actions we can just copy & paste the new code 👍
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 02a1659. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We can use GitHub Actions' standard features not Jinja2 features to generate test image names.
What changes are included in this PR?
Use
GITHUB_ENV
instead of Jinja2.Are these changes tested?
Yes.
Are there any user-facing changes?
No.