-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44629: [C++][Acero] Use implicit_ordering
for asof_join
rather than require_sequenced_output
#44616
base: main
Are you sure you want to change the base?
GH-44629: [C++][Acero] Use implicit_ordering
for asof_join
rather than require_sequenced_output
#44616
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -563,14 +563,17 @@ class ARROW_DS_EXPORT ScanNodeOptions : public acero::ExecNodeOptions { | |
public: | ||
explicit ScanNodeOptions(std::shared_ptr<Dataset> dataset, | ||
std::shared_ptr<ScanOptions> scan_options, | ||
bool require_sequenced_output = false) | ||
bool require_sequenced_output = false, | ||
bool implicit_ordering = false) | ||
: dataset(std::move(dataset)), | ||
scan_options(std::move(scan_options)), | ||
require_sequenced_output(require_sequenced_output) {} | ||
require_sequenced_output(require_sequenced_output), | ||
implicit_ordering(implicit_ordering) {} | ||
|
||
std::shared_ptr<Dataset> dataset; | ||
std::shared_ptr<ScanOptions> scan_options; | ||
bool require_sequenced_output; | ||
bool implicit_ordering; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUC, |
||
}; | ||
|
||
/// @} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4077,13 +4077,15 @@ cdef class _ScanNodeOptions(ExecNodeOptions): | |
cdef: | ||
shared_ptr[CScanOptions] c_scan_options | ||
bint require_sequenced_output=False | ||
bint implicit_ordering=False | ||
|
||
c_scan_options = Scanner._make_scan_options(dataset, scan_options) | ||
|
||
require_sequenced_output=scan_options.get("require_sequenced_output", False) | ||
implicit_ordering=scan_options.get("implicit_ordering", False) | ||
|
||
self.wrapped.reset( | ||
new CScanNodeOptions(dataset.unwrap(), c_scan_options, require_sequenced_output) | ||
new CScanNodeOptions(dataset.unwrap(), c_scan_options, require_sequenced_output, implicit_ordering) | ||
) | ||
|
||
|
||
|
@@ -4101,8 +4103,8 @@ class ScanNodeOptions(_ScanNodeOptions): | |
expression or projection to the scan node that you also supply | ||
to the filter or project node. | ||
|
||
Yielded batches will be augmented with fragment/batch indices to | ||
enable stable ordering for simple ExecPlans. | ||
Yielded batches will be augmented with fragment/batch indices when | ||
implicit_ordering=True to enable stable ordering for simple ExecPlans. | ||
|
||
Parameters | ||
---------- | ||
|
@@ -4111,7 +4113,9 @@ class ScanNodeOptions(_ScanNodeOptions): | |
**kwargs : dict, optional | ||
Scan options. See `Scanner.from_dataset` for possible arguments. | ||
require_sequenced_output : bool, default False | ||
Assert implicit ordering on data. | ||
Batches are yielded sequentially, like single-threaded | ||
Comment on lines
4115
to
+4116
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this still needed? |
||
implicit_ordering : bool, default False | ||
Preserve implicit ordering of data. | ||
""" | ||
|
||
def __init__(self, Dataset dataset, **kwargs): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there are documents of these two fields in the python counterpart. Could you add them in C++ too so this can be self-explaining?