Skip to content

Commit

Permalink
Apply comment fixes
Browse files Browse the repository at this point in the history
Co-authored-by: Sutou Kouhei <[email protected]>
  • Loading branch information
pitrou and kou authored Jan 7, 2025
1 parent b3ce08c commit d63abfd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions ci/docker/python-wheel-windows-test-vs2019-base.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ FROM abrarov/msvc-2019:2.11.0
# Add unix tools to path
RUN setx path "%path%;C:\Program Files\Git\usr\bin"

# 1. Remove previous installations of python from the base image
# NOTE: a more recent base image (tried with 2.12.1) comes with python 3.9.7
# and the msi installers are failing to remove pip and tcl/tk "products" making
# the subsequent choco python installation step failing for installing python
# 1. Remove previous installations of Python from the base image
# NOTE: a more recent base image (tried with 2.12.1) comes with Python 3.9.7
# and the MSI installers are failing to remove pip and tcl/tk "products" making
# the subsequent choco python installation step failing for installing Python
# version 3.9.* due to existing python version
# 2. Install Minio for S3 testing.
RUN wmic product where "name like 'python%%'" call uninstall /nointeractive && \
Expand Down
10 changes: 5 additions & 5 deletions ci/docker/python-wheel-windows-vs2019-base.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ RUN vcpkg install \
--x-feature=parquet \
--x-feature=s3

# Remove previous installations of python from the base image
# NOTE: a more recent base image (tried with 2.12.1) comes with python 3.9.7
# and the msi installers are failing to remove pip and tcl/tk "products" making
# the subsequent choco python installation step failing for installing python
# version 3.9.* due to existing python version
# Remove previous installations of Python from the base image
# NOTE: a more recent base image (tried with 2.12.1) comes with Python 3.9.7
# and the MSI installers are failing to remove pip and tcl/tk "products" making
# the subsequent choco python installation step failing for installing Python
# version 3.9.* due to existing Python version
RUN wmic product where "name like 'python%%'" call uninstall /nointeractive && \
rm -rf Python*

0 comments on commit d63abfd

Please sign in to comment.