Skip to content

Commit

Permalink
GH-45041: [Packaging][Python] Use ORC from vcpkg instead of bundled o…
Browse files Browse the repository at this point in the history
…n Linux and macOS (#45046)

### Rationale for this change

We are currently downloading and building ORC every time for our wheels. We should not require to bundle ORC ourselves and we could just use vcpkg.

### What changes are included in this PR?

Stop using `ORC_SOURCE=BUNDLED` and enable the vcpkg orc feature.

### Are these changes tested?

Yes, on the wheels.

### Are there any user-facing changes?

No

* GitHub Issue: #45041

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
raulcd authored Dec 17, 2024
1 parent 2bd2e35 commit 6c9e7e7
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions ci/docker/python-wheel-manylinux.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ RUN --mount=type=secret,id=github_repository_owner \
--x-feature=flight \
--x-feature=gcs \
--x-feature=json \
--x-feature=orc \
--x-feature=parquet \
--x-feature=s3 && \
rm -rf ~/.config/NuGet/
Expand Down
1 change: 0 additions & 1 deletion ci/scripts/python_wheel_macos_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ cmake \
-DCMAKE_INSTALL_PREFIX=${build_dir}/install \
-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-DORC_SOURCE=BUNDLED \
-DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
-DVCPKG_MANIFEST_MODE=OFF \
-DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
Expand Down
1 change: 0 additions & 1 deletion ci/scripts/python_wheel_manylinux_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ cmake \
-DCMAKE_INSTALL_LIBDIR=lib \
-DCMAKE_INSTALL_PREFIX=/tmp/arrow-dist \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
-DORC_SOURCE=BUNDLED \
-DPARQUET_REQUIRE_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION} \
-DVCPKG_MANIFEST_MODE=OFF \
-DVCPKG_TARGET_TRIPLET=${VCPKG_TARGET_TRIPLET} \
Expand Down
1 change: 1 addition & 0 deletions dev/tasks/python-wheels/github.osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
--x-feature=flight \
--x-feature=gcs \
--x-feature=json \
--x-feature=orc \
--x-feature=parquet \
--x-feature=s3
Expand Down

0 comments on commit 6c9e7e7

Please sign in to comment.