GH-463: Improve TZ support for JDBC driver #464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiguofer
requested review from
lidavidm,
laurentgo and
wgtmac
as code owners
jduo
reviewed
Jan 14, 2025
| @@ -58,6 +71,7 @@ public ArrowFlightJdbcTimeStampVectorAccessor( | |||
| this.holder = new Holder(); | |||
| this.getter = createGetter(vector); | |||
|
|
|||
| this.isZoned = getVectorIsZoned(vector); | |||
| this.timeZone = getTimeZoneForVector(vector); | |||
There was a problem hiding this comment.
It's a bit strange that both the timeZone and isZoned field exist and would be good to clarify why/how they are used and are different.
There was a problem hiding this comment.
Yeah, originally I thought about setting tz to null if not available but there's some expectations about timeZone not being null and having some default value in a few places where it felt like untangling would make this too big. I'll add some comments.
jduo
reviewed
Jan 14, 2025
| @@ -120,7 +120,12 @@ public static int getSqlTypeIdFromArrowType(ArrowType arrowType) { | |||
| case Time: | |||
| return Types.TIME; | |||
| case Timestamp: | |||
| return Types.TIMESTAMP; | |||
| String tz = ((ArrowType.Timestamp) arrowType).getTimezone(); | |||
| if (tz != null){ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a draft PR to address #463. Looking for feedback here, and we can either merge individual pieces or the whole thing at once.