Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Controller dosenot depend on TableService #3425

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[Improvement]: Controller dosenot depend on TableService #3425

wants to merge 8 commits into from

Conversation

baiyangtx
Copy link
Contributor

@baiyangtx baiyangtx commented Jan 23, 2025 •
edited
Loading

Why are the changes needed?

As a subtask of #3346, this PR will make RestController do not depend on TableService which is a statefull service

Brief change log

  • Caculate TableOptimizingInfo from database meta.
  • Cancel process through a thrift api call to OptimizingService

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:ams-server Ams server module module:common type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baiyangtx