Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3404] Correct the description about MySQL usage #3416

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

klion26
Copy link
Member

@klion26 klion26 commented Jan 22, 2025

Why are the changes needed?

Close #3404.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Jan 22, 2025
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@zhoujinsong zhoujinsong merged commit c69a236 into apache:master Jan 22, 2025
1 check passed
@klion26
Copy link
Member Author

klion26 commented Jan 22, 2025

@zhoujinsong thanks for the review and merging!

@klion26 klion26 deleted the 3404 branch January 22, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Correct the documentation for MySQL usage
2 participants