-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-3387]fix: create table like using mixed_hive #3387
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3387 +/- ##
============================================
+ Coverage 21.64% 27.80% +6.15%
- Complexity 2316 3589 +1273
============================================
Files 427 599 +172
Lines 39751 48597 +8846
Branches 5630 6266 +636
============================================
+ Hits 8605 13510 +4905
- Misses 30419 34149 +3730
- Partials 727 938 +211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
provider.isDefined match { | ||
case true => | ||
throw new UnsupportedOperationException( | ||
s"format ${provider.get} does not support create table like command!!!") | ||
case false => plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation may impact the logic of other extensions when multiple extensions are used together.
It is recommended to handle only the scenarios you are concerned with in the case conditions =>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your reviews. I remove the provider.isDefined
check and return plan directly
Why are the changes needed?
Enviroment:
format: mixed_hive
engine: spark3.3
catalog:
sparkUnifiedSessionCatalog
bug:
table created by using
create table like using mixed_hive
is not a mixed_hive table.Brief change log
mixed_hive
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation