Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable PT006 rule #45389

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

enable PT006 rule #45389

wants to merge 3 commits into from

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Jan 4, 2025

related to #40567

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 4, 2025
@rawwar
Copy link
Collaborator Author

rawwar commented Jan 4, 2025

Used ruff check --fix --select PT006 --unsafe-fixes to fix all the PT006 failures. But, also looking into what are the "unsafe" cases and update the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk Awaiting requested review from potiuk potiuk will be requested when the pull request is marked ready for review potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb will be requested when the pull request is marked ready for review ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham will be requested when the pull request is marked ready for review jedcunningham is a code owner

@eladkal eladkal Awaiting requested review from eladkal eladkal will be requested when the pull request is marked ready for review eladkal is a code owner

@mobuchowski mobuchowski Awaiting requested review from mobuchowski mobuchowski will be requested when the pull request is marked ready for review mobuchowski is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas will be requested when the pull request is marked ready for review o-nikolas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:webserver Webserver related Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rawwar