-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate canary-run condition in run-tests SelectiveChecks #45387
Conversation
I think it would be better to reevaluate 'run-tests' condition in this case in |
Yeah make sense , i think i got it where its failing check, let me get updated changes.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Precisely :)
This will help cases like when
run-tests
becomes false if it is canary-run .Some times tests are getting skipped in canary run.
We have condition in jobs to trigger for
run-tests
, even thought this works but often some timesrun-tests
becomes false when the last merge commit main has only some UI changes. then this causing skipping of canary run tests jobs. see below it has skipped most of the jobs. because the selective check here https://github.com/apache/airflow/actions/runs/12602875121/job/35126775759#step:8:217 triggered only the ui file changeshttps://github.com/apache/airflow/actions/runs/12602875121/job/35126775759
https://github.com/apache/airflow/actions/runs/12602875121/job/35126775759#step:8:310
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.