Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fail stop dag property to fail fast #45327

Merged

Conversation

hprassad
Copy link
Contributor

@hprassad hprassad commented Jan 1, 2025

closes: #45229
This PR renames fail_stop DAG property to fail_fast, the changes made to relevant files


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jan 1, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@amoghrajesh
Copy link
Contributor

@hprassad FYI, I updated your PR description to link the issue.

@Lee-W Lee-W added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Jan 2, 2025
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'm good with this PR, but we'll need a newsfragment for it

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of occurences which have been missed in tests.
Ref:
image

Also, needs a newsfragment addition. Example: https://github.com/apache/airflow/pull/43902/files#diff-802ca1cc091ad2e4489cfdb8cb02678d0bc42db3a6b9081859a2ee66b415b94e

@amoghrajesh
Copy link
Contributor

@Lee-W do we have to add this one into migration rules too?

@Lee-W
Copy link
Member

Lee-W commented Jan 2, 2025

@Lee-W do we have to add this one into migration rules too?

Yes, this can be easily detected. I’ll create a PR for this later

@potiuk potiuk force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from b92cd31 to d108d45 Compare January 2, 2025 12:37
@potiuk
Copy link
Member

potiuk commented Jan 2, 2025

@hprassad - I rebased it -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests.

@hprassad hprassad requested review from amoghrajesh and Lee-W January 2, 2025 14:08
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the changes look good @hprassad. Can you please add newsfragment as mentioned by @Lee-W?

hprassad added a commit to hprassad/airflow that referenced this pull request Jan 3, 2025
@hprassad
Copy link
Contributor Author

hprassad commented Jan 3, 2025

@amoghrajesh & @Lee-W , I have added file in newsfragments folder for the PR

@hprassad hprassad requested review from amoghrajesh and Lee-W January 4, 2025 06:40
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but looks good to me! Thanks @hprassad!

I would also wait for approval from @Lee-W on this.

newsfragments/45327.significant.rst Outdated Show resolved Hide resolved
@eladkal eladkal added this to the Airflow 3.0.0 milestone Jan 13, 2025
@amoghrajesh
Copy link
Contributor

@hprassad Few checks are failing. Can you please take a look and fix it?

@amoghrajesh
Copy link
Contributor

@hprassad gentle ping. Could you please handle the review comments and rebase this Pull Request? We are waiting on this one for #44951

@Lee-W Lee-W force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from 2952acc to d25c241 Compare January 20, 2025 09:50
@Lee-W
Copy link
Member

Lee-W commented Jan 20, 2025

@amoghrajesh I just updated it. Please take a final look. Once this is merged, I'll create a ruff PR for migration rule. Thanks!

@Lee-W Lee-W requested a review from potiuk as a code owner January 20, 2025 09:53
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good

newsfragments/45327.significant.rst Outdated Show resolved Hide resolved
@Lee-W Lee-W force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from aed2f42 to 2fae4f2 Compare January 20, 2025 10:19
@Lee-W Lee-W merged commit a76af4f into apache:main Jan 21, 2025
92 checks passed
Copy link

boring-cyborg bot commented Jan 21, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@amoghrajesh
Copy link
Contributor

@hprassad congratulations on your first PR merge! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:task-sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename fail_stop DAG property to fail_fast
5 participants