Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FAB to 4.5.1 #43251

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Upgrade FAB to 4.5.1 #43251

merged 1 commit into from
Oct 23, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 22, 2024

FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the upgrade-to-fab-4.5.1 branch from 1996e78 to f1e91e1 Compare October 22, 2024 09:41
@potiuk potiuk requested a review from jedcunningham as a code owner October 22, 2024 09:41
@potiuk
Copy link
Member Author

potiuk commented Oct 22, 2024

OK. I know why it failed - seems like old change of mine (adding constraints) did not take into account that sometimes constraints might be conflicting with local deps (like in this case where we pin FAB). Fix in #43276

FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.
@potiuk potiuk force-pushed the upgrade-to-fab-4.5.1 branch from f1e91e1 to 0a3bc99 Compare October 23, 2024 07:59
@potiuk
Copy link
Member Author

potiuk commented Oct 23, 2024

Merging it - there is an openlineage mypy issue that will be addressed separately.

@potiuk potiuk merged commit 84ff10b into apache:main Oct 23, 2024
105 of 106 checks passed
@potiuk potiuk deleted the upgrade-to-fab-4.5.1 branch October 23, 2024 13:12
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 23, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.

(cherry picked from commit 84ff10b)
@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 23, 2024
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 23, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.

(cherry picked from commit 84ff10b)
kaxil pushed a commit that referenced this pull request Oct 23, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.

(cherry picked from commit 84ff10b)
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.
@utkarsharma2 utkarsharma2 added type:misc/internal Changelog: Misc changes that should appear in change log changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Oct 24, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.

(cherry picked from commit 84ff10b)
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:fab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants