ARTEMIS-5232 Clean up on testsuite for speed #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmellr
reviewed
Jan 10, 2025
tests/activemq5-unit-tests/src/test/java/org/apache/activemq/RedeliveryPolicyTest.java
Outdated
Show resolved
Hide resolved
...emis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
Show resolved
Hide resolved
...java/org/apache/activemq/artemis/tests/integration/cluster/distribution/ClusterTestBase.java
Outdated
Show resolved
Hide resolved
.../activemq/artemis/tests/integration/cluster/distribution/LargeMessageRedistributionTest.java
Outdated
Show resolved
Hide resolved
...pache/activemq/artemis/tests/integration/cluster/distribution/MessageRedistributionTest.java
Outdated
Show resolved
Hide resolved
...pache/activemq/artemis/tests/integration/cluster/distribution/MessageRedistributionTest.java
Show resolved
Hide resolved
...apache/activemq/artemis/tests/integration/cluster/distribution/TwoWayTwoNodeClusterTest.java
Show resolved
Hide resolved
clebertsuconic
force-pushed
the
ARTEMIS-5232
branch
3 times, most recently
from
8e92c7b to
91c82bb
Compare
This test does not make sense much sense. The barrier does not seem to always work It is sleeping for 11 seconds for no reason. I didn't want to accept it when it was committed in the first place so i'm removing it
…verSessionNoCommit This test makes no sense to me. This Wait.assertEquals seems to be doing just a regular sleep. If I actually properly fixed the test with assertTrue on this Wait clause the test would always fail. Meaning the test is completely broken. Since this test is not actually testing anything I'm just removing it as other tests are already validating redeliveries
clebertsuconic
force-pushed
the
ARTEMIS-5232
branch
2 times, most recently
from
0407ca5 to
e964905
Compare
- Avoid unecessary duplications in inheritance (mainly LargeMessage and FailoverTest) - Fixed some time outs and sleeps between restart of servers - Fixed some configuration options - Tweak in a few tests
clebertsuconic
force-pushed
the
ARTEMIS-5232
branch
from
e964905 to
715533b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.