Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-5210 bump com.google.errorprone:error_prone_core from 2.31.0 to 2.36.0 #5395

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jbertram
Copy link
Contributor

No description provided.

@clebertsuconic
Copy link
Contributor

What these other changes have to do with the component upgrade?

Can they be separate commits with a better description?

@jbertram
Copy link
Contributor Author

jbertram commented Dec 12, 2024

@clebertsuconic, these change are required because running with -Perrorprone will fail without them since the duplicate branches are marked as errors.

@gemmellr
Copy link
Member

gemmellr commented Dec 12, 2024

I'm fine with the other changes, they make sense overall, but are only being done due to the upgrade so it seems reaosonable enough to bundle them. I just think the commented-out-code shouldnt be there, better nothing.

I did also type and delete 'maybe we could disable/downgrade-to-warning that new check?' before suggesting just to delete the comment since I'm fine with the changes. I'm also fine with effetively-same/duplicate branches where its clearer though, so I'd be fine without the check also.

@clebertsuconic
Copy link
Contributor

@jbertram sure.. delete it.

@jbertram
Copy link
Contributor Author

@clebertsuconic, done!

@clebertsuconic clebertsuconic merged commit a2357b9 into apache:main Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants