Disables HTML escaping in LoadPlan json encoding. #5299
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The encoding in LoadPlan was using GSon default settings which encoded some HTML chars like `=` as unicode escape sequences. This did not cause any problems because GSon would reverse this encoding. However it was not documented in the javadoc for LoadPlan and it seems unnecessary. Disabled the HTML escaping so the code aligns w/ the javadoc. Also updated the unit test to produce `=` in the base64 and see how that behaves in the json. This allows the test to better detect changes in the way the code persist data.
alerman
approved these changes
Feb 3, 2025
dlmarion
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encoding in LoadPlan was using GSon default settings which encoded some HTML chars like
=as unicode escape sequences. This did not cause any problems because GSon would reverse this encoding. However it was not documented in the javadoc for LoadPlan and it seems unnecessary.Disabled the HTML escaping so the code aligns w/ the javadoc. Also updated the unit test to produce
=in the base64 and see how that behaves in the json. This allows the test to better detect changes in the way the code persist data.