Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better arm support #139

Merged
merged 6 commits into from
May 3, 2024
Merged

Better arm support #139

merged 6 commits into from
May 3, 2024

Conversation

aous72
Copy link
Owner

@aous72 aous72 commented May 3, 2024

The main contribution of this PR is to improve the build process.
This was instigated by changes in GitHub runners, whereby Intel-based Mac machines are not longer employed.

We modify two options from CMakeLists.txt, which are

  • Replacing OJPH_DISABLE_INTEL_SIMD with OJPH_DISABLE_SIMD. The new option should be architecture agnostic.
  • Replacing OJPH_ENABLE_INTEL_AVX512 with OJPH_DISABLE_AVX512. This is because AVX512 is supported by both Intel and AMD.
    We also added a few options to disable using particular instruction sets: SSE, SSE2, SSSE3, SSE4, AVX, AVX2 and AVX512. It is left to the end user to decide what best suits them. Removing an option can be due to that it is missing from the compiler, or to reduce the resulting code size.
    Notice that all instructions are enabled by default and need to be disabled if desired,
    We add better support for ARM -- No NEON code yet.
    Also added more Actions.

This should address issues #111 and #121.

@aous72 aous72 merged commit d4ea880 into master May 3, 2024
8 checks passed
@aous72 aous72 deleted the better_arm_support branch May 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant