Enable eslint rule and reject with errors instead of strings

[kox]

Following #13 , this PR intends to enable the eslint rule: prefer-promise-reject-errors as error.

I believe that treating promise rejections as errors ensures better handling and propagation of the rejection reason to the final components. The affected package tests have been updated accordingly.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 204f681

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[steveluscher]

The reason property of an AbortSignal can actually be an Error.

Consider the difference between:

const ac = new AbortController();
ac.signal.addEventListener('abort', function () { console.log(this.reason.constructor, this.reason); })
ac.abort();

…and…

const ac = new AbortController();
ac.signal.addEventListener('abort', function () { console.log(this.reason.constructor, this.reason); })
ac.abort('o no');

reason is a DOMException in the first, and a String in the second.

I think there are only two ways forward here:

• Leave this as is, suppress the lint.
• If the reason is typeof string then wrap it in an Error. Otherwise, reject with reason directly.

I think the second raises more questions than it answers, so I'm inclined to do the first.

[kox]

Following your concerns and for simplicity, I suppressed the lints and introduced Errors inside of a test and an example.

[steveluscher]

I still think the Error conversions need to go.

[kox]

Sorry about that. I took a deeper look into the AbortController and AbortSignal and you are right about it. It doesn't make sense to wrap it in an extra Error.

[steveluscher]

Thanks for improving our code quality!