Refactor - Removes the dense function registry from loaders #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/removes_dense_function_registry
branch
2 times, most recently
from
75135da to
3f9244d
Compare
LucasSte
reviewed
Jan 30, 2025
src/program.rs
Outdated
| @@ -304,13 +275,9 @@ impl<C: ContextObject> BuiltinProgram<C> { | |||
| /// Get the function registry depending on the SBPF version | |||
| pub fn get_function_registry( | |||
| &self, | |||
| sbpf_version: SBPFVersion, | |||
| _sbpf_version: SBPFVersion, | |||
There was a problem hiding this comment.
What about removing the unused parameter?
test_utils/src/lib.rs
Outdated
| $function_registry | ||
| .register_function_hashed($location.as_bytes(), $syscall_function) | ||
| .unwrap(); | ||
| (register, $loader:expr, $location:expr => $syscall_function:expr) => { |
There was a problem hiding this comment.
What about calling name instead of location?
test_utils/src/lib.rs
Outdated
| }; | ||
| ($source:tt, $config:tt, $mem:tt, ($($location:expr => $syscall_function:expr),* $(,)?), $context_object:expr, $expected_result:expr $(,)?) => { | ||
| ($source:expr, $config:expr, $mem:expr, ($($location:expr => $syscall_function:expr),* $(,)?), $context_object:expr, $expected_result:expr $(,)?) => { |
There was a problem hiding this comment.
Name instead of location?
test_utils/src/lib.rs
Outdated
| test_interpreter_and_jit!(executable, $mem, $context_object, $expected_result); | ||
| } | ||
| }; | ||
| ($source:tt, $mem:tt, ($($location:expr => $syscall_function:expr),* $(,)?), $context_object:expr, $expected_result:expr $(,)?) => { | ||
| ($source:expr, $mem:expr, ($($location:expr => $syscall_function:expr),* $(,)?), $context_object:expr, $expected_result:expr $(,)?) => { |
Lichtso
force-pushed
the
refactor/removes_dense_function_registry
branch
from
3f9244d to
7fd164c
Compare
LucasSte
approved these changes
Jan 30, 2025
Comment on lines
+13
to
15
| use solana_sbpf::program::SBPFVersion; | ||
| use solana_sbpf::vm::Config; | ||
| use solana_sbpf::{assembler::assemble, ebpf, program::BuiltinProgram}; |
There was a problem hiding this comment.
Not for this PR, but we could configure cargo fmt to group imports as we do in the Agave repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.