reuses a thread-local weighted-shuffle for get_retransmit_addrs #4805
+63
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
cluster-nodes-thread-local
branch
3 times, most recently
from
fa452a2 to
009d694
Compare
get_retransmit_addrs does a lot of allocations to clone WeightedShuffle: https://github.com/anza-xyz/agave/blob/a3be62584/turbine/src/cluster_nodes.rs#L223 Using a thread-local variable along with WeightedShuffle::clone_from allows to hold on to the allocation, reuse the same previously allocated memory, and minimize allocations.
behzadnouri
force-pushed
the
cluster-nodes-thread-local
branch
from
009d694 to
d6cf34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
get_retransmit_addrsdoes a lot of allocations to cloneWeightedShuffle:https://github.com/anza-xyz/agave/blob/a3be62584/turbine/src/cluster_nodes.rs#L223
Summary of Changes
The commit uses a thread-local variable along with
WeightedShuffle::clone_fromto hold on to the allocation, reuse the same previously allocated memory, and minimize allocations.