sdk: Create new Cargo workspace for sdk/ #4685
Draft
+5,282
−339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `solana-sdk` depends on `solana-bn254` and `solana-secp256k1-recover`, but they currently live in the `curves/` subdirectory. When the sdk gets moved to a new Cargo workspace and repository, it needs to have all of its solana crate dependencies, which is not currently the case. #### Summary of changes Move `curves/bn254` and `curves/secp256k1-recover` into `sdk/`, and update all paths as needed.
#### Problem We want to move everything under `sdk/` into a standalone repository, but all of the crates are currently part of the monorepo workspace, which makes the extraction impossible. #### Summary of changes Remove all crates in `sdk/` from the top-level workspace, but keep the local dependency. Create a new `Cargo.toml` for the sdk workspace along with all required dependencies and patches.
kevinheavey
reviewed
Jan 29, 2025
| lto = "thin" | ||
|
|
||
| [workspace] | ||
| members = [ |
There was a problem hiding this comment.
thoughts on making an sdk/crates dir so everything can just be moved in there and this field can be members = ["crates/*"]?
There was a problem hiding this comment.
Personally, I'm going to get way more annoyed about having to type crates (or c<TAB>) every single time I want to open a file in the repo over having to update this field whenever a new crate is added.
But I might be in the minority.
joncinque
force-pushed
the
sdkworkspace
branch
from
a57ab67 to
4541d4d
Compare
joncinque
force-pushed
the
sdkworkspace
branch
from
4541d4d to
bf5635f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to move everything under
sdk/into a standalone repository, but all of the crates are currently part of the monorepo workspace, which makes the extraction impossible.Summary of changes
Remove all crates in
sdk/from the top-level workspace, but keep the local dependency. Create a newCargo.tomlfor the sdk workspace along with all required dependencies and patches. Finally, remove unused dependencies in the sdk's Cargo.toml.Note: this builds on #4675, leaving in draft until that lands