stops refreshing legacy gossip NodeInstance and Version #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainnet nodes are running v2.0.15 and v2.1.5 at a minimum, both of which are using the new ContactInfo to look up version: https://github.com/anza-xyz/agave/blob/v2.0.15/gossip/src/cluster_info.rs#L1336-L1338 https://github.com/anza-xyz/agave/blob/v2.1.5/gossip/src/cluster_info.rs#L1316-L1317 and to check for duplicate instance: https://github.com/anza-xyz/agave/blob/v2.0.15/gossip/src/cluster_info.rs#L2504-L2505 https://github.com/anza-xyz/agave/blob/v2.1.5/gossip/src/cluster_info.rs#L2481-L2482 So we no longer need to refresh and push legacy gossip NodeInstance and Version.
behzadnouri
force-pushed
the
gossip-stop-push-version
branch
from
5c91965 to
085ab7f
Compare
gregcusack
reviewed
Jan 29, 2025
Comment on lines
+2112
to
+2115
| if nodes.any(|other| my_contact_info.check_duplicate(other)) { | ||
| Err(GossipError::DuplicateNodeInstance) | ||
| } else { | ||
| Ok(()) |
There was a problem hiding this comment.
isn't this going to discard all ContactInfo in nodes even if only one of them is a duplicate?
There was a problem hiding this comment.
This is not discarding any values.
It just checks for duplicate and returns an error if it finds a duplicate.
There was a problem hiding this comment.
oh ya this function is checking for duplicates of its own contact info. not duplicates of other contact infos. makes sense that it would return early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mainnet nodes are running v2.0.15 and v2.1.5 at a minimum, both of which are using the new
ContactInfoto look up version:https://github.com/anza-xyz/agave/blob/v2.0.15/gossip/src/cluster_info.rs#L1336-L1338
https://github.com/anza-xyz/agave/blob/v2.1.5/gossip/src/cluster_info.rs#L1316-L1317
and to check for duplicate instance:
https://github.com/anza-xyz/agave/blob/v2.0.15/gossip/src/cluster_info.rs#L2504-L2505
https://github.com/anza-xyz/agave/blob/v2.1.5/gossip/src/cluster_info.rs#L2481-L2482
So we no longer need to refresh and push legacy gossip
NodeInstanceandVersion.Summary of Changes
The commit stops refreshing legacy gossip
NodeInstanceandVersion.