Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove activated feature code #4676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: remove activated feature code #4676

wants to merge 1 commit into from

Conversation

tao-stones
Copy link

@tao-stones tao-stones commented Jan 28, 2025 •
edited
Loading

Problem

Feature https://github.com/anza-xyz/feature-gate-tracker/issues/21 has activated everywhere.

solana feature status BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF -ut
Feature                                      | Status                  | Activation Slot | Description
BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF | active since epoch 715  | 303356256       | Removing unwanted rounding in fee calculation #34982

solana feature status BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF -ud
Feature                                      | Status                  | Activation Slot | Description
BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF | active since epoch 802  | 346464000       | Removing unwanted rounding in fee calculation #34982

solana feature status BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF -um
Feature                                      | Status                  | Activation Slot | Description
BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF | active since epoch 734  | 317088000       | Removing unwanted rounding in fee calculation #34982

Summary of Changes

  • remove feature specific code

Fixes #

@tao-stones tao-stones force-pushed the refactor-remove-feature-code-21 branch from 3ceb4cf to 135b4e8 Compare January 29, 2025 16:46
@tao-stones tao-stones force-pushed the refactor-remove-feature-code-21 branch from 135b4e8 to 2d0d7df Compare January 29, 2025 16:47
@tao-stones tao-stones marked this pull request as ready for review January 29, 2025 20:16
@tao-stones tao-stones requested review from a team as code owners January 29, 2025 20:16
@tao-stones tao-stones requested a review from apfitzge January 29, 2025 20:17
apfitzge
apfitzge reviewed Jan 29, 2025
View reviewed changes
fee/src/lib.rs
remove_rounding_in_fee_calculation(pub),
enable_secp256r1_precompile(pub)
)
field_qualifiers(enable_secp256r1_precompile(pub))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tao-stones I have asked Pankaj to revert the change that introduced this change (only became aware of it due to this PR).
Would prefer a clean revert commit, so going to wait for his response to my comment before approving this PR.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the revert: #4694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgarg66 pgarg66 pgarg66 left review comments

@apfitzge apfitzge apfitzge left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tao-stones @apfitzge @pgarg66