-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Adds UpgradeableLoaderInstruction::Migrate
#4661
base: master
Are you sure you want to change the base?
Feature - Adds UpgradeableLoaderInstruction::Migrate
#4661
Conversation
The Firedancer team maintains a line-for-line reimplementation of the |
ba4a1ef
to
d9db125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is failing.
programs/bpf_loader/src/lib.rs
Outdated
)?; | ||
|
||
invoke_context.native_invoke( | ||
solana_loader_v4_interface::instruction::truncate_uninitialized( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does truncate also increase the account size? If so, the name might be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Truncate
can also increase the size and it is common for file systems to only have one function for both directions: https://www.man7.org/linux/man-pages/man2/truncate.2.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see linux use the same naming, but we can improve our designation and call it resize
.
Truncate means shortening: https://www.collinsdictionary.com/dictionary/english/truncate
d9db125
to
c526f4d
Compare
Yep, also still have to write a test for the new instruction. |
a5b2de4
to
a141a1a
Compare
2ccc774
to
e5f2665
Compare
The Firedancer team maintains a line-for-line reimplementation of the |
This PR contains changes to the solana sdk, which will be moved to a new repo within the next week, when v2.2 is branched from master. Please merge or close this PR as soon as possible, or re-create the sdk changes when the new repository is ready at https://github.com/anza-xyz/solana-sdk |
538e50e
to
ae58ed5
Compare
The Firedancer team maintains a line-for-line reimplementation of the |
ae58ed5
to
ea3afea
Compare
Problem
See SIMD-0167.
Summary of Changes
Feature Gate Issue: https://github.com/anza-xyz/feature-gate-tracker/issues/78