extract rpc-client-api-core without reqwest dep #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @kevinheavey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-rpc-client-apidepends onreqwestfor some marginal things. This is really annoying as it brings in dependencies that make compile times worse, increase conflicts and make the crate less portable, even though reqwest is only being used for itsErrortype.Summary of Changes
solana-rpc-client-api-corecrate, which is basically everything fromsolana-rpc-client-apithat doesn't needreqwestsolana-rpc-client-apifor backwards compatibilityThis would supersede #4038 and #2961 which are still awaiting review. I don't care which PRs get chosen but I would really like to get rid of the reqwest dep before 2.2 is cut