refactor: introduce SnapshotMode enum as a replacement for SnapshotCo… #4659
+134
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeySlomowitz
force-pushed
the
refactor_introduce-snapshot-mode
branch
from
0411797 to
8661818
Compare
JoeySlomowitz
force-pushed
the
refactor_introduce-snapshot-mode
branch
from
8661818 to
cf0f414
Compare
…nfig struct refactor: introduce new SnapshotMode enum cleanup remove unnecessary struct
JoeySlomowitz
force-pushed
the
refactor_introduce-snapshot-mode
branch
from
cf0f414 to
f688ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cleanup task was requested on the old repo here
Summary of Changes
This introduces snapshot_mode.rs with
SnapshotMode(enum) and some defaults that aim to re-produce existing functionality in snapshot_config.rs