svm: add program cache tests #4656
Open
+220
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you re-work the program cache, please also update the concurrent tests available here: https://github.com/anza-xyz/agave/blob/master/svm/tests/concurrent_tests.rs |
|
this changes nothing but tests so im assuming one approval only from svm group is fine |
LucasSte
previously approved these changes
Jan 29, 2025
Lichtso
reviewed
Jan 29, 2025
svm/tests/mock_bank.rs
Outdated
| ); | ||
|
|
||
| // Other loaders are needed for testing program cache behavior. | ||
| // NOTE when LoaderV4 is ready for testing, it must be added here. |
Lichtso
reviewed
Jan 29, 2025
svm/tests/integration_test.rs
Outdated
| fn svm_integration(test_entries: Vec<SvmTestEntry>) { | ||
| for test_entry in test_entries { | ||
| let env = SvmTestEnvironment::create(test_entry); | ||
| env.execute(); | ||
| } | ||
| } | ||
|
|
||
| #[test_matrix([false, true], [false, true])] | ||
| fn program_cache_create_account(enable_fee_only_transactions: bool, disable_executable_flag: bool) { |
There was a problem hiding this comment.
disable_executable_flag => remove_accounts_executable_flag_checks
It only removes the checks of the flag, not the flag itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we are planning on refactoring transaction processing to use a per-transaction (changed from per-batch) local program cache. this requires new logic for handling tombstones, which lacks test coverage
Summary of Changes
add tests. also fix a bug in the svm test framework for setting program upgrade authority, and improve logging failures for better test-driven development