Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump sccache to v0.9.1 #4655

Merged
merged 2 commits into from
Jan 30, 2025
Merged

ci: bump sccache to v0.9.1 #4655

merged 2 commits into from
Jan 30, 2025

Conversation

yihau
Copy link
Member

@yihau yihau commented Jan 28, 2025

Problem

Summary of Changes

Fixes #

@yihau yihau marked this pull request as ready for review January 28, 2025 10:27
@yihau yihau added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 28, 2025
@yihau yihau mentioned this pull request Jan 28, 2025
Merged
@yihau yihau requested review from ryoqun and willhickey January 29, 2025 03:10
@ryoqun
Copy link
Collaborator

ryoqun commented Jan 29, 2025

I can confirm there's now a newer docker image with sccache v0.9.1 (thanks!). however, it seems there are still several places sccache v0.8.1 is used...:

$ git grep -E "v0\\.8\\.1([^0-9]|$)" yihau/bump-sccache-version :^RELEASE.md
yihau/bump-sccache-version:.github/workflows/downstream-project-anchor.yml:          version: "v0.8.1"
yihau/bump-sccache-version:.github/workflows/downstream-project-spl.yml:          version: "v0.8.1"
yihau/bump-sccache-version:.github/workflows/downstream-project-spl.yml:          version: "v0.8.1"
yihau/bump-sccache-version:ci/docker/Dockerfile:  SCCACHE_VERSION=v0.8.1 \

Especially, i think it's okay to update the ci/docker/Dockerfile in this pr at once among them.

@yihau
Copy link
Member Author

yihau commented Jan 29, 2025

oh. good catch. let me update them now!

@anza-team
Copy link
Collaborator

😱 New commits were pushed while the automerge label was present.

@anza-team anza-team removed the automerge automerge Merge this Pull Request automatically once CI passes label Jan 29, 2025
ryoqun
ryoqun approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@yihau yihau merged commit 644091a into anza-xyz:master Jan 30, 2025
44 checks passed
@yihau yihau deleted the bump-sccache-version branch January 30, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryoqun ryoqun ryoqun approved these changes

@willhickey willhickey Awaiting requested review from willhickey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihau @ryoqun @anza-team