moves repair nonce verification from window-service to shred-fetch-stage #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
shred-fetch-verify-nonce
branch
8 times, most recently
from
f6d26f3 to
ea70ad2
Compare
behzadnouri
force-pushed
the
shred-fetch-verify-nonce
branch
from
ea70ad2 to
6355743
Compare
Because repair nonce is a randomly generated u32 for each repair request, it can be verified before sigverify so that shreds with invalid repair nonce do not waste sigverify resources.
behzadnouri
force-pushed
the
shred-fetch-verify-nonce
branch
from
6355743 to
3abc306
Compare
AshwinSekar
approved these changes
Jan 30, 2025
steviez
approved these changes
Jan 30, 2025
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Feb 5, 2025
prune_shreds_elapsed_us and num_shreds_pruned_invalid_repair are leftovers of: anza-xyz#4641 and are no longer measuring anything. Separately, num_repairs can be atomically updated inside the thread-pool during the first iteration, and does not need an additional iteration over the packets.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Feb 5, 2025
prune_shreds_elapsed_us and num_shreds_pruned_invalid_repair are leftovers of: anza-xyz#4641 and are no longer measuring anything. Separately, num_repairs can be atomically updated inside the thread-pool during the first iteration, and does not need an additional iteration over the packets.
behzadnouri
added a commit
that referenced
this pull request
Feb 5, 2025
prune_shreds_elapsed_us and num_shreds_pruned_invalid_repair are leftovers of: #4641 and are no longer measuring anything. Separately, num_repairs can be atomically updated inside the thread-pool during the first iteration, and does not need an additional iteration over the packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because repair nonce is a randomly generated u32 for each repair request, it can be verified before sigverify so that shreds with invalid repair nonce do not waste sigverify resources.
Summary of Changes
The commit moves repair nonce verification from window-service to shred-fetch-stage.
This bypasses sigverify and a full deserialization for shreds with invalid repair nonce.