sdk: Move out things that won't be in the sdk #4624
Conversation
#### Problem The Solana sdk will soon have a standalone repository, but the `sdk/` directory in the agave repo contains some things that won't move over. #### Summary of changes Move the following and update paths: * cargo-build-sbf * cargo-test-sbf * sdk/sbf * gen-headers
| mkdir -p "$installDir"/bin/platform-tools-sdk/sbf | ||
| cp -a platform-tools-sdk/sbf/* "$installDir"/bin/platform-tools-sdk/sbf |
There was a problem hiding this comment.
This is the change I'm least sure about, I'm not sure if it will break any existing tooling to put the sbf sdk in a new directory during installation
There was a problem hiding this comment.
will we use the sdk dir name for storing sdk related items in the future? If not, I think we can keep this one. if I don't miss anything, this will be located in the end user’s system, so the name might not need to reflect our source 🤔 (line 223)
btw, if we decide to keep the original struct, we may need to update the logic in cargo-build-sbf and cargo-test-sbf
There was a problem hiding this comment.
I thought it would be more confusing to use a different directory between the monorepo and the release. My hope is that there's no sdk/ in agave in the future, and that we can even move platform-tool-sdk out too!
I'll keep this then, thanks!
| mkdir -p "$installDir"/bin/platform-tools-sdk/sbf | ||
| cp -a platform-tools-sdk/sbf/* "$installDir"/bin/platform-tools-sdk/sbf |
There was a problem hiding this comment.
will we use the sdk dir name for storing sdk related items in the future? If not, I think we can keep this one. if I don't miss anything, this will be located in the end user’s system, so the name might not need to reflect our source 🤔 (line 223)
btw, if we decide to keep the original struct, we may need to update the logic in cargo-build-sbf and cargo-test-sbf
Problem
The Solana sdk will soon have a standalone repository, but the
sdk/directory in the agave repo contains some things that won't move over.
Summary of changes
Move the following and update paths:
NOTE: Leaving in draft to see how CI goesCI passed!