Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds benchmark for shred::merkle::make_shreds_from_data #4602

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions ledger/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ features = ["lz4"]

[dev-dependencies]
bs58 = { workspace = true }
criterion = { workspace = true }
solana-account-decoder = { workspace = true }
solana-logger = { workspace = true }
solana-runtime = { workspace = true, features = ["dev-context-only-utils"] }
Expand All @@ -116,6 +117,10 @@ name = "sigverify_shreds"
[[bench]]
name = "blockstore"

[[bench]]
name = "make_shreds_from_entries"
harness = false

[package.metadata.docs.rs]
targets = ["x86_64-unknown-linux-gnu"]

Expand Down
140 changes: 140 additions & 0 deletions ledger/benches/make_shreds_from_entries.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
#![allow(clippy::arithmetic_side_effects)]
use {
criterion::{black_box, criterion_group, criterion_main, Criterion},
rand::Rng,
solana_entry::entry::Entry,
solana_ledger::shred::{ProcessShredsStats, ReedSolomonCache, Shred, Shredder},
solana_sdk::{
hash::Hash, packet::PACKET_DATA_SIZE, pubkey::Pubkey, signer::keypair::Keypair,
transaction::Transaction,
},
std::iter::repeat_with,
};

fn make_dummy_hash<R: Rng>(rng: &mut R) -> Hash {
Hash::from(rng.gen::<[u8; 32]>())
}

fn make_dummy_transaction<R: Rng>(rng: &mut R) -> Transaction {
solana_sdk::system_transaction::transfer(
&Keypair::new(), // from
&Pubkey::from(rng.gen::<[u8; 32]>()), // to
rng.gen(), // lamports
make_dummy_hash(rng), // recent_blockhash
)
}

fn make_dummy_entry<R: Rng>(rng: &mut R) -> Entry {
let count = rng.gen_range(1..20);
let transactions = repeat_with(|| make_dummy_transaction(rng))
.take(count)
.collect();
Entry::new(
&make_dummy_hash(rng), // prev_hash
1, // num_hashes
transactions,
)
}

fn make_dummy_entries<R: Rng>(rng: &mut R, data_size: usize) -> Vec<Entry> {
let mut serialized_size = 8; // length prefix.
repeat_with(|| make_dummy_entry(rng))
.take_while(|entry| {
serialized_size += bincode::serialized_size(entry).unwrap();
serialized_size < data_size as u64
})
.collect()
}

fn make_shreds_from_entries<R: Rng>(
rng: &mut R,
shredder: &Shredder,
keypair: &Keypair,
entries: &[Entry],
is_last_in_slot: bool,
chained_merkle_root: Option<Hash>,
reed_solomon_cache: &ReedSolomonCache,
stats: &mut ProcessShredsStats,
) -> (Vec<Shred>, Vec<Shred>) {
let (data, code) = shredder.entries_to_shreds(
keypair,
entries,
is_last_in_slot,
chained_merkle_root,
rng.gen_range(0..2_000), // next_shred_index
rng.gen_range(0..2_000), // next_code_index
true, // merkle_variant
reed_solomon_cache,
stats,
);
(black_box(data), black_box(code))
}

fn run_make_shreds_from_entries(
name: &str,
c: &mut Criterion,
num_packets: usize,
is_last_in_slot: bool,
) {
let mut rng = rand::thread_rng();
let slot = 315_892_061 + rng.gen_range(0..=100_000);
let parent_offset = rng.gen_range(1..=u16::MAX);
let shredder = Shredder::new(
slot,
slot - u64::from(parent_offset), // parent_slot
rng.gen_range(0..64), // reference_tick
rng.gen(), // shred_version
)
.unwrap();
let keypair = Keypair::new();
let data_size = num_packets * PACKET_DATA_SIZE;
let entries = make_dummy_entries(&mut rng, data_size);
let chained_merkle_root = Some(make_dummy_hash(&mut rng));
let reed_solomon_cache = ReedSolomonCache::default();
let mut stats = ProcessShredsStats::default();
// Initialize the thread-pool and warm the Reed-Solomon cache.
for _ in 0..10 {
make_shreds_from_entries(
&mut rng,
&shredder,
&keypair,
&entries,
is_last_in_slot,
chained_merkle_root,
&reed_solomon_cache,
&mut stats,
);
}
c.bench_function(name, |b| {
b.iter(|| {
let (data, code) = make_shreds_from_entries(
&mut rng,
&shredder,
&keypair,
&entries,
is_last_in_slot,
chained_merkle_root,
&reed_solomon_cache,
&mut stats,
);
black_box(data);
black_box(code);
})
});
}

fn bench_make_shreds_from_entries(c: &mut Criterion) {
for is_last_in_slot in [false, true] {
for num_packets in [16, 20, 24, 28, 32, 48, 64, 96, 128, 256] {
let name = format!(
"bench_make_shreds_from_entries_{}{}",
if is_last_in_slot { "last_" } else { "" },
num_packets
);
run_make_shreds_from_entries(&name, c, num_packets, is_last_in_slot);
}
}
}

criterion_group!(benches, bench_make_shreds_from_entries,);
criterion_main!(benches);
Loading