Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch some functions in net-utils to tokio #4524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch some functions in net-utils to tokio #4524

wants to merge 1 commit into from
+188 −102

Conversation

alexpyattaev
Copy link

@alexpyattaev alexpyattaev commented Jan 17, 2025 •
edited
Loading

Problem

There is a bunch of code in net-utils that could be better implemented with tokio rather than std sockets. This is primarily to address a bigger problem as outlined in #4440, but also async implementations are nicer and cleaner.

Summary of Changes

  • Switched implementation of fn ip_echo_server_request in net-utils towards tokio (std TCP sockets do not support BINDTODEVICE)
  • Updated do_verify_reachable_ports to be async as well. It will now also verify all TCP ports concurrently (used to be serial).

@alexpyattaev alexpyattaev force-pushed the net_utils_rework branch 3 times, most recently from 572d5ea to 6fb6eb4 Compare January 17, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcusack gregcusack Awaiting requested review from gregcusack

@bw-solana bw-solana Awaiting requested review from bw-solana

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexpyattaev