remove solana-sdk from some cli modules #4496
Open
+73
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
cli-reduce-sdk-use
branch
4 times, most recently
from
2f4c6a0 to
a490137
Compare
kevinheavey
force-pushed
the
cli-reduce-sdk-use
branch
from
a490137 to
47e8c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-cli doesn't need solana-sdk but removing it all in one go would make a very big PR
Summary of Changes
remove it from address_lookup_table.rs, checks.rs and cli.rs