Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract big-mod-exp crate #4491

Merged
merged 6 commits into from
Jan 19, 2025
Merged

Conversation

kevinheavey
Copy link

Problem

This module imposes a solana-program dep on solana-bpf-loader-program. That's a litesvm dependency so I'm particularly keen to kick solana-program out of it

Summary of Changes

Move to its own crate and re-export with deprecation note

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of bits, then this can go in

sdk/big-mod-exp/Cargo.toml Outdated Show resolved Hide resolved
sdk/big-mod-exp/Cargo.toml Outdated Show resolved Hide resolved
programs/sbf/Cargo.lock Outdated Show resolved Hide resolved
svm/examples/Cargo.lock Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! @yihau can you accept ownership of solana-big-mod-exp?

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 19, 2025
@mergify mergify bot merged commit 73650a1 into anza-xyz:master Jan 19, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants