[merlin, zk-sdk] Turn default-features for merlin
crate to false
#4469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When building
zk-sdk
withcargo-build-sbf
, I get the following errorThe default features in the
merlin
crate, whichzk-sdk
depends on usesrand_core
.Summary of Changes
I set
default-features = false
for themerlin
crate, which resolves the above error withcargo-build-sbf
(thanks @joncinque!).After I remove the default features, it complains that the
transcript
module inside zk-sdk is not used intarget_os = "solana"
builds. Not sure why it did not complain before, but I added excluded thetranscript
module from thetarget_os = "solana"
target build.Fixes #