Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit lints from workspace for programs/sbf #4463

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

LucasSte
Copy link

Problem

In #4439, we noticed that simply adding unexpected_cfgs to the workspace lints would still raise lints errors for programs/sbf.

Summary of Changes

When using rust nightly, we must inherit the lint specification from the workspace so that they can be correctly applied.

@LucasSte LucasSte requested review from brooksprumo and yihau January 14, 2025 23:01
@LucasSte LucasSte marked this pull request as ready for review January 14, 2025 23:01
@LucasSte LucasSte changed the title Inhering lints from workspace for programs/sbf Inherit lints from workspace for programs/sbf Jan 14, 2025
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LucasSte LucasSte merged commit 30111d0 into anza-xyz:master Jan 14, 2025
36 checks passed
@LucasSte LucasSte deleted the lints branch January 14, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants