-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make dcou partitioned steps not-skewed and cached #4452
Changes from all commits
85c5907
04ad98f
fe498bf
de1ac38
5151153
9e832e8
ec70612
43206a7
7a6ab12
892a781
aea0ee9
54686ae
e438cc3
3353ef9
9f70de7
239a55d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ ARG \ | |
RUST_NIGHTLY_VERSION= \ | ||
GOLANG_VERSION=1.21.3 \ | ||
NODE_MAJOR=18 \ | ||
SCCACHE_VERSION=v0.8.1 \ | ||
SCCACHE_VERSION=v0.9.1 \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this newer version starts to show cache hit rates by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bumped the version here: #4655 |
||
GRCOV_VERSION=v0.8.18 | ||
|
||
SHELL ["/bin/bash", "-o", "pipefail", "-c"] | ||
|
@@ -78,7 +78,9 @@ RUN \ | |
rustup component add llvm-tools-preview --toolchain=$RUST_NIGHTLY_VERSION && \ | ||
rustup target add wasm32-unknown-unknown && \ | ||
cargo install cargo-audit && \ | ||
cargo install cargo-hack && \ | ||
# uncomment once the dcou-parition related patch is upstreamed... | ||
# cargo install cargo-hack && \ | ||
cargo install --git https://github.com/anza-xyz/cargo-hack.git --rev 5e59c3ec6c661c02601487c0d4b2a2649fe06c9f cargo-hack && \ | ||
cargo install cargo-sort && \ | ||
cargo install mdbook && \ | ||
cargo install mdbook-linkcheck && \ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,29 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -eo pipefail | ||
source ./ci/_ | ||
|
||
(unset RUSTC_WRAPPER; cargo install --force --git https://github.com/anza-xyz/cargo-hack.git --rev 5e59c3ec6c661c02601487c0d4b2a2649fe06c9f cargo-hack) | ||
|
||
# Here, experimentally switch the sccache storage from GCS to local disk by | ||
# `unset`-ing gcs credentials so that sccache automatically falls back to the | ||
# local disk storage. | ||
unset SCCACHE_GCS_KEY_PATH SCCACHE_GCS_BUCKET SCCACHE_GCS_RW_MODE SCCACHE_GCS_KEY_PREFIX | ||
|
||
# sccache's default is 10G, but our boxes have far more storage. :) | ||
export SCCACHE_CACHE_SIZE="200G" | ||
|
||
# Disable incremental compilation as this is documented as not-compatible with | ||
# sccache at https://github.com/mozilla/sccache/blob/v0.9.1/README.md#rust | ||
# > Incrementally compiled crates cannot be cached. | ||
export CARGO_INCREMENTAL=0 | ||
|
||
_ sccache --show-stats | ||
|
||
scripts/check-dev-context-only-utils.sh check-all-targets "$@" | ||
scripts/check-dev-context-only-utils.sh check-bins-and-lib "$@" | ||
|
||
# This shows final stats while stopping the sccache background server as well | ||
# for later normal sccache use (if any). Remember that sccache is now | ||
# temporarily and experimtally running with the local disk storage. | ||
_ sccache --stop-server |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,6 +151,15 @@ fi | |
# consistency with other CI steps and for the possibility of new similar lints. | ||
export RUSTFLAGS="-D warnings -Z threads=8 $RUSTFLAGS" | ||
|
||
# As this environment value is used by the rather deep crate of our dep graph | ||
# (solana-varsion), this could invalidate significant portion of caches when | ||
# this changes just with a new tiny commit. Technically, it's possible for | ||
# CI_COMMIT to affect the outcome of compilation via build.rs, but it's | ||
# extremely unrealistic for such diverting compilation behaviors to be desired | ||
# as a sane use-case. So, just unset CI_COMMIT unconditionally to increase | ||
# cache efficiency. | ||
unset CI_COMMIT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fyi, I put this |
||
|
||
if [[ $mode = "check-bins-and-lib" || $mode = "full" ]]; then | ||
_ cargo "+${rust_nightly}" hack "$@" check | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi,
/var/lib/buildkite/...
didn't work well due to permission issue...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you dm me the failed build link?oh, if this one works, then let's use it