counts received gossip packets inside the thread-pool #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
count-gossip-packets-par
branch
4 times, most recently
from
6985f0e to
582d1b4
Compare
We already traverse packets inside the thread-pool and know the variant, so might as well count packets there instead of a separate traversal.
behzadnouri
force-pushed
the
count-gossip-packets-par
branch
from
582d1b4 to
6dda03f
Compare
| } | ||
| } | ||
| let mut counts = [0u64; 7]; | ||
| let mut dropped_packets_counts = [0u64; 7]; |
There was a problem hiding this comment.
It would be nice to make a struct for these. This is bound to explode at some point.
There was a problem hiding this comment.
The struct is indeed self.stats; see record_dropped_packets.
But we need to map the enum identifier (u32) to the struct fields somewhere and that is what the combination of dopped_packet_counts and record_dropped_packets try to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We already traverse packets inside the thread-pool and know the variant, so might as well count packets there instead of a separate traversal.
Summary of Changes
The commit counts received gossip packets inside the thread-pool.