LocalCluster - rename, refactor consts, verify initial transfers #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
changed the title
apfitzge
commented
Jan 13, 2025
| @@ -1432,7 +1432,7 @@ pub mod test { | |||
| initialize_and_add_secondary_indexes(&mut validator_config); | |||
| let num_nodes = 1; | |||
| let mut config = ClusterConfig { | |||
| cluster_lamports: 10_000_000, | |||
There was a problem hiding this comment.
could probably get rid of all these lower values as well...I can't imagine there's anything special about these that require lower mint lamports
There was a problem hiding this comment.
could either do them in this PR, or just up them if these tests fail once fees are added.
apfitzge
commented
Jan 13, 2025
| @@ -278,10 +280,18 @@ impl LocalCluster { | |||
| stake, | |||
| )) | |||
| } else { | |||
| required_mint_lamports += Self::required_validator_funding(*stake); | |||
There was a problem hiding this comment.
working on making local cluster tests (and all tests) have fees.
This line will change as we need to add additional lamports to pay for fees.
apfitzge
commented
Jan 13, 2025
apfitzge
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Additional context: #4394 - I'm removing the special-casing in our fee-calculation for zero fees in tests. This requires some changes in several places, including local-cluster tests. Splitting these changes out to make the fee-related changes simpler to do.
Summary of Changes
cluster_lamportsis not the total cluster lamports...its' themint_lamports. Change the name