Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use solana-instruction instead of solana-sdk in solana-stake-program #4432

Merged

Conversation

kevinheavey
Copy link

Same idea as #4327

This program uses the one-line utility function checked_add which is in solana-program but not in solana-instruction. I just copied it to this crate as was already done with the system program and address lookup table program

Copy link

mergify bot commented Jan 13, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 13, 2025
@mergify mergify bot merged commit 60612b8 into anza-xyz:master Jan 13, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants