cli: add feature revoke #4361
Merged
cli: add feature revoke #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
feature-revoke-cli
branch
2 times, most recently
from
1a272e0 to
8e73a3b
Compare
buffalojoec
force-pushed
the
feature-revoke-cli
branch
from
8e73a3b to
b8d72cf
Compare
joncinque
reviewed
Jan 15, 2025
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "f1056507c534839b5cd1b1010ffedb9e8c92313269786fb5066ff53b30326dc3" | ||
| dependencies = [ | ||
| "borsh 0.10.3", |
There was a problem hiding this comment.
Outside the scope of this PR, but the generated client should be compatible with borsh v1 if it's upgraded.
| @@ -14,6 +14,9 @@ use { | |||
| input_validators::*, keypair::*, | |||
| }, | |||
| solana_cli_output::{cli_version::CliVersion, QuietDisplay, VerboseDisplay}, | |||
| solana_feature_gate_client::{ | |||
| errors::SolanaFeatureGateError, instructions::RevokePendingActivation, | |||
There was a problem hiding this comment.
nit: Outside the scope of this PR, but FeatureGateError would be a better name for the type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new Feature Gate Core BPF program is live at
Feature111111...on both testnet and devnet, and will soon be on mainnet-beta.With this new program, we can revoke features that are pending activation. The program has only one instruction,
RevokePendingActivation, which simply "closes" a newly created feature account by:However, core contributors who wish to use this new capability have no way of doing so from the CLI.
Summary of Changes
Add a new command to the
solana featureCLI that invokes theRevokePendingActivationinstruction on the Feature Gate program to revoke a pending activation.For more information about this instruction, see the program's instruction source. However, in summary, once a feature is activated with
solana feature activate, it can be revoked at any time before the epoch rollover, while the state is still zeroed. Once the epoch concludes and the feature is activated by the runtime, the account is bestowed with validFeaturestate and thus can no longer be revoked.