Ensure that hashing across account data and resize area works #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firedancer team maintains a line-for-line reimplementation of the |
seanyoung
force-pushed
the
hashers
branch
2 times, most recently
from
d5f28a1 to
0434fc2
Compare
Lichtso
reviewed
Dec 4, 2024
Lichtso
reviewed
Dec 4, 2024
| n_bytes: u64, | ||
| accounts: &[SerializedAccountMetadata], | ||
| memory_mapping: &MemoryMapping, | ||
| mut fun: F, |
There was a problem hiding this comment.
This could be a &mut dyn FnMut, instead of a generic.
There was a problem hiding this comment.
Do we really want &mut dyn FnMut?
- It's such a short function, code bloat shouldn't be an issue (I think)
fn iter_memory_pair_chunks()is also generic (so then both should be changed)
generic is "better inlining and optimization, but larger code" and dyn is "shorter slower code, indirect calling is expensive and fewer optimizations possible".
wdyt?
seanyoung
force-pushed
the
hashers
branch
2 times, most recently
from
c0c65ac to
391319f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The account data consists of two areas: the orignal account data and the resize area, for when the account size is increased. Hashing across these two regions does not work, since they are distinct regions.
This change is required for direct mapping.
See stricter VM verfication SIMD