Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract fee-structure crate #3311

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

kevinheavey
Copy link

Problem

solana_sdk::fee imposes a solana_sdk dependency on solana_svm and solana_compute_budget

Summary of Changes

  • Move to its own crate and re-export with deprecation in solana_sdk. I've named the new crate solana-fee-structure based on the top level doc comment for fee.rs. solana-fee is already taken.
  • Make serde optional in the new crate
  • Add doc_auto_cfg

@kevinheavey kevinheavey force-pushed the extract-fee-structure branch from 983f960 to e0ab766 Compare October 25, 2024 11:01
@kevinheavey kevinheavey requested a review from febo October 26, 2024 09:51
@kevinheavey kevinheavey force-pushed the extract-fee-structure branch 2 times, most recently from a4f4cfd to 88f2247 Compare October 29, 2024 09:26
@kevinheavey kevinheavey force-pushed the extract-fee-structure branch from 3d0ba71 to f48956b Compare October 29, 2024 23:18
Copy link

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – just one micro nit.

@febo
Copy link

febo commented Oct 30, 2024

One more question. solana-fee at the moment depends on the solana_sdk::fee::FeeDetails. Should that be updated to point to this new crate on this PR or the plan is to do it in a separate PR?

@kevinheavey
Copy link
Author

Separate PR :)

I try to avoid touching other crates in these PRs ever since I had to rebase #2172 13 times

@febo
Copy link

febo commented Oct 30, 2024

Sounds good – @yihau could we please accept the crate ownership?

@yihau
Copy link
Member

yihau commented Oct 30, 2024

@febo febo merged commit 5ebb6a5 into anza-xyz:master Oct 30, 2024
52 checks passed
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
* extract fee-structure crate

* add doc_auto_cfg

* missing dep

* fix frozen-abi support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants