Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prioritization_fee_cache: remove get_account_locks #2556

Merged

Conversation

apfitzge
Copy link

Problem

  • validate_account_locks function got pulled into account_locks from sdk
  • following that change, get_account_locks and get_account_locks_unchecked will be deprecated
  • prioritization_fee_cache uses get_account_locks

Summary of Changes

  • Replace use of get_account_locks with more direct access

Fixes #

@apfitzge apfitzge self-assigned this Aug 12, 2024
@apfitzge apfitzge marked this pull request as ready for review August 12, 2024 16:05
@apfitzge apfitzge requested a review from tao-stones August 12, 2024 16:05
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.enumerate()
.filter(|(index, _)| message.is_writable(*index))
.map(|(_, key)| *key)
.collect();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional saving from filtering out read-only accounts 👍🏼

@apfitzge apfitzge merged commit 8b22b92 into anza-xyz:master Aug 13, 2024
41 checks passed
@apfitzge apfitzge deleted the prioritization_fee_cache_account_locks branch August 13, 2024 18:32
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants