Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new validate_account_locks #2553

Merged
merged 4 commits into from
Aug 13, 2024
Merged

use new validate_account_locks #2553

merged 4 commits into from
Aug 13, 2024

Conversation

apfitzge
Copy link

Problem

  • Legacy SanitizedTransaction::validate_account_locks is used in a few places
  • We want to use the new function which does not force specific transaction/message type(s)

Summary of Changes

  • Change direct uses of SanitizedTransaction::validate_account_locks to validate_account_locks

Fixes #

apfitzge
apfitzge commented Aug 12, 2024
View reviewed changes
accounts-db/src/lib.rs
@@ -5,7 +5,7 @@
extern crate lazy_static;

pub mod account_info;
mod account_locks;
pub mod account_locks;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be pub so we can actually use the function outside accounts-db

@apfitzge apfitzge self-assigned this Aug 12, 2024
@apfitzge apfitzge marked this pull request as ready for review August 12, 2024 15:54
@apfitzge apfitzge requested a review from tao-stones August 12, 2024 15:54
tao-stones
tao-stones approved these changes Aug 13, 2024
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit e181194 into anza-xyz:master Aug 13, 2024
41 checks passed
@apfitzge apfitzge deleted the use_new_validate_account_locks branch August 13, 2024 18:32
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@apfitzge @ray-kast
use new validate_account_locks (anza-xyz#2553)
9d204ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees

@apfitzge apfitzge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @tao-stones