hash-cache-tool: Scan files with mmap and bins #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accounts-db/src/pubkey_bins.rs
Outdated
| @@ -11,12 +11,12 @@ impl PubkeyBinCalculator24 { | |||
| std::mem::size_of::<T>() * 8 | |||
| } | |||
|
|
|||
| pub(crate) fn log_2(x: u32) -> u32 { | |||
| pub fn log_2(x: u32) -> u32 { | |||
There was a problem hiding this comment.
doesn't probably matter, but is this necessary?
There was a problem hiding this comment.
No, not necessary. Let me revert that.
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The accounts hash cache tool can be faster by scanning mmap'd files, and then optionally binning the results by pubkey. These binned results will be used when constructing the full state to diff in the next PR.
Summary of Changes
Scanning entries uses mmap'd files into bins.