Improve type safety in stake state module #2482
Conversation
There was a problem hiding this comment.
The change looks good to me! What do you think about taking it a step further and adding #![deny(clippy::wildcard_enum_match_arm)] at the top of the file to catch future occurrences?We don't do this anywhere else in the code, but it might make sense for sensitive modules like this one.
Sounds like a great idea to me. We should probably use that more often in the codebase. I just updated the PR with that clippy config and an additional refactor to remove another instance of a wildcard arm |
|
Needs a rebase on master |
jstarry
force-pushed
the
refactor/stake-state-type-safety
branch
from
d953435 to
2649c7b
Compare
jstarry
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
jstarry
added
the
automerge
* improve type safety in stake state module * feedback * fix new method
Problem
Many stake state methods use catch-all match cases for remaining variants, so a new variant could be unintentionally unhandled.
Brought up by @behzadnouri in #2453 (comment)
Summary of Changes
Add explicit match cases for all stake state variants.
Fixes #