TransactionView: InstructionsMeta #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Aug 8, 2024
| result::Result, | ||
| }; | ||
|
|
||
| /// Contains meta-data about the instructions in a transaction packet. |
There was a problem hiding this comment.
Suggested change
| /// Contains meta-data about the instructions in a transaction packet. | |
| /// Contains metadata about the instructions in a transaction packet. |
| fn test_zero_instructions() { | ||
| let bytes = bincode::serialize(&ShortVec(Vec::<CompiledInstruction>::new())).unwrap(); | ||
| let mut offset = 0; | ||
| assert!(InstructionsMeta::try_new(&bytes, &mut offset).is_ok()); |
There was a problem hiding this comment.
Should we check in this case that the number of instructions is zero?
There was a problem hiding this comment.
Yeah idk how I missed that when writing.
I added some additional asserts on the offset as well: ed84c80
LucasSte
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #