Update BankHashDetails to include EpochAccountsHash #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
commented
Aug 6, 2024
brooksprumo
reviewed
Aug 7, 2024
brooksprumo
reviewed
Aug 7, 2024
steviez
force-pushed
the
slot_details_eah
branch
from
15cca05 to
17c6f67
Compare
brooksprumo
reviewed
Aug 20, 2024
The EpochAccountsHash gets mixed into a Bank hash once an epoch. It is just as important as the other items, and it was an oversight for the field not to be included to BankHashDetails. So, add EpochAccountsHash into BankHashDetails
steviez
force-pushed
the
slot_details_eah
branch
from
a08a557 to
24a894b
Compare
steviez
commented
Aug 20, 2024
There was a problem hiding this comment.
I had to rebase in order to resolve a conflict. The reason for the conflict shifted some things around and rebasing got a little messy. Given that and how small the PR is, so I squashed the commits to "reset" the review process in a sense. Given that it is only 11 lines, I don't see this as a huge deal so hopefully you agree 😅
brooksprumo
approved these changes
Aug 21, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
The EpochAccountsHash gets mixed into a Bank hash once an epoch. It is just as important as the other items, and it was an oversight for the field not to be included to BankHashDetails. So, add EpochAccountsHash into BankHashDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The EpochAccountsHash gets mixed into a Bank hash once an epoch. It is
just as important as the other items, and it was an oversight for the
field not to be included to BankHashDetails.
Summary of Changes
So, add EpochAccountsHash into BankHashDetails